-
Notifications
You must be signed in to change notification settings - Fork 52
Utilize VT if possible #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, do not pre-create as many threads as many cores reported by Java as many times they are simply unused.
Proof why "rebuild on each Java version" pattern is totally wrong: The CI. The JARs should be built on controlled Java + Maven version and then test performed on matrix, as right now, what you can use is really matrix minimum and that is outright silly. |
It is easier configuration ... |
Thanks! Still, the reason I dislike this is that consumer may rightfully ask "and what Java was used to release this?" -- as we basically make a feature depend on Java version we use to release. The proposed solution (use one version to build and enforce it) makes the presence of feature clear, and not kinda optional-ish. Also, if someone releases this library and by mistake use Java 17 or 11 (as library is Java 8+), nothing will happen: no big red alarm will ring, and the only way to figure out what happened is to inspect the release output Java... |
Or simply, faster switch to Java 21 |
I added check in release profile to use 21+, so we will not have a mistake |
We can merge it ... |
Also, lessen the pressure (creating eagerly as many threads as many CPU cores per archive is a huge pressure), as many times they are simply unused.